Skip to content

subscriber: correct spans in Directive::parse #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

subscriber: correct spans in Directive::parse #3297

wants to merge 1 commit into from

Conversation

@DaniPopes
Copy link

@DaniPopes DaniPopes commented Jun 4, 2025

Motivation

Noticed in #3243 that the main loop iterates over from.trim().char_indices(), but i is used to index into the untrimmed from.

Solution

Reassign from.

@DaniPopes
subscriber: correct spans in Directive::parse
c3d6ce4 
`i` refers to `from.trim()` but `from` is used when indexing.
@DaniPopes DaniPopes requested review from a team, davidbarsky and hawkw as code owners June 4, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkw hawkw Awaiting requested review from hawkw hawkw is a code owner

@davidbarsky davidbarsky Awaiting requested review from davidbarsky davidbarsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DaniPopes